[feature] #2048: Add toolchain file #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
mversic
previously approved these changes
Apr 1, 2022
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan
approved these changes
Apr 4, 2022
mversic
approved these changes
Apr 4, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…ha#2049) Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…ha#2049) Signed-off-by: Daniil Polyakov <[email protected]>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added toolchain file setting up rustc to version 1.57
Issue
Closes #2048
Benefits
Now project can be build without additional steps like
rustup overridePossible Drawbacks
Not a drawback, but at first I thought that will be a way to set different toolchains for different tools.
Unfortunatly we still have to use
cargo +<toolchain> ...forclippyandfmt.This situation looks a bit like
clippyproblem with multiple sub-crates, so that we have to usecargo lints