[feature] #2056: Add a derive proc macro crate for AssetValueType enum #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilchu
requested review from
Arjentix,
QuentinI,
SamHSmith,
appetrosyan,
mversic,
outoftardis and
s8sato
as code owners
github-actions
bot
added
the
iroha2-dev
ilchu
force-pushed
the
from-str-proc-macro
branch
3 times, most recently
from
7b7ef44 to
e65dc29
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2213 +/- ##
==================================
==================================
Continue to review full report at Codecov.
|
ilchu
force-pushed
the
from-str-proc-macro
branch
2 times, most recently
from
a91ff6e to
87f4395
Compare
…ssetValueType enum Signed-off-by: Ilia Churin <[email protected]>
ilchu
force-pushed
the
from-str-proc-macro
branch
from
87f4395 to
cc6242a
Compare
appetrosyan
approved these changes
May 17, 2022
Contributor
appetrosyan
left a comment
appetrosyan
left a comment
There was a problem hiding this comment.
I'm happy we didn't need to add a custom implementation. Good job!
s8sato
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilia Churin [email protected]
Description of the Change
Added a crate with a proc macro to
data_modelthat allows automatically derivingFromStrimpls for any enums exhaustively.Issue
Resolves #2056.
Benefits
FromStrderived automatically for all variants instead of having to list them manually as was done with a declarative macro.Possible Drawbacks
Doubtful if this new dependency should be placed into
data_modelor in themacrocrate and then re-exported. Opted for the former.