[fix] #2215: Make nightly optional for building Iroha. #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appetrosyan
requested review from
Arjentix,
QuentinI,
SamHSmith,
mversic,
outoftardis and
s8sato
as code owners
github-actions
bot
added
the
iroha2-dev
appetrosyan
changed the title
s8sato
previously approved these changes
May 17, 2022
appetrosyan
force-pushed
the
i2-build-improve
branch
from
69f1099 to
3a612d0
Compare
s8sato
approved these changes
May 17, 2022
mversic
approved these changes
May 17, 2022
| // Build and format the smartcontract if and only if the tests are | ||
| // invoked with the nightly toolchain. We should not force our | ||
| // users to have the `nightly` if we don't use any `nightly` | ||
| // features in the actual binary. |
…argo build` Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan
force-pushed
the
i2-build-improve
branch
from
3a612d0 to
0644463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
April release
See #2216