Skip to content

refactor!: rename TransactionValue into CommittedTransaction #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mversic merged 1 commit into from
May 17, 2024
Merged

refactor!: rename TransactionValue into CommittedTransaction #4610

mversic merged 1 commit into from
May 17, 2024

Conversation

@mversic
Copy link
Contributor

@mversic mversic commented May 17, 2024

Description

closes #4517

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label May 17, 2024
@mversic mversic enabled auto-merge (squash) May 17, 2024 05:48
@mversic mversic merged commit bf789ef into hyperledger-iroha:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

2 more reviewers

@nxsaken nxsaken nxsaken approved these changes

@Erigara Erigara Erigara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-changes Changes in the API for client libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename TransactionValue into CommittedTransaction

3 participants

@mversic @nxsaken @Erigara