Skip to content

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 18, 2024

Description

Rename the configs directory to defaults since that's what it really is (default docker compose configs, default executor.wasm, default genesis.json, etc.)

Linked issue

Closes #4293, #4320

Benefits

Conveys the purpose of the directory better.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic
Copy link
Contributor

mversic commented Jul 18, 2024

This was renamed for the 5th time already. We have to agree on this for once

@nxsaken nxsaken requested a review from 0x009922 July 24, 2024 06:31
0x009922
0x009922 previously approved these changes Jul 24, 2024
@nxsaken nxsaken enabled auto-merge (squash) July 26, 2024 07:37
mversic
mversic previously approved these changes Jul 26, 2024
@nxsaken nxsaken merged commit bbcb27f into hyperledger-iroha:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[discussion] Rename configs/swarm?

3 participants