refactor!: remove max prefix from blocks_in_memory
#5145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
0x009922,
DCNick3,
Erigara,
SamHSmith,
dima74,
outoftardis and
s8sato
as code owners
0x009922
requested changes
Oct 11, 2024
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
Please update peer.template.toml too.
0x009922
added
the
config-changes
0x009922
requested changes
Oct 11, 2024
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
And it seems this parameter is not covered in *.toml in fixures. Could you add it there and ensure it passes?
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
rename_kura_max_blocks_in_memory
branch
from
b33df4d to
79f7d05
Compare
Contributor
Author
done |
Erigara
approved these changes
Oct 14, 2024
0x009922
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5108