Get rid of Hashtable in NodeStats #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, deduplicate the implementations for all the different kinds of backoff.
Reuse the existing implementation for obtaining the TimedStats.
Bombe
approved these changes
May 29, 2025
Comment on lines
+3614
to
+3619
| List<TimedStats> stats = new ArrayList<>(); | ||
| averages.forEach((key, avg) -> stats.add( | ||
| new TimedStats(key, avg.countReports(), (long) avg.currentValue(), (long) avg.totalValue()) | ||
| )); | ||
| Collections.sort(stats); | ||
| return stats.toArray(new TimedStats[0]); |
Contributor
There was a problem hiding this comment.
Can I make a suggestion?
Suggested change
| List<TimedStats> stats = new ArrayList<>(); | |
| averages.forEach((key, avg) -> stats.add( | |
| new TimedStats(key, avg.countReports(), (long) avg.currentValue(), (long) avg.totalValue()) | |
| )); | |
| Collections.sort(stats); | |
| return stats.toArray(new TimedStats[0]); | |
| return averages.entrySet().stream() | |
| .map(entry -> new TimedStats(entry.getKey(), entry.getValue().countReports(), (long) entry.getValue().currentValue(), (long) entry.getValue().totalValue())) | |
| .sorted() | |
| .toArray(TimedStats[]::new); |
I just ❤️ the goddamn Streams API so much. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the Hashtables can easily be replaced by ConcurrentHashMap. This reduces potential lock contention (see also #989 for related work) in the node stats reporting, and simplifies the code by using modern constructs like
computeIfAbsentand factoring out common code.