renderer: remove opengl:nvidia_anti_flicker#12118
Closed
fxzzi wants to merge 1 commit intohyprwm:mainfrom
Closed
Conversation
Contributor
Author
|
i realise this is useless anyway since we check for explicit sync anyway lol |
Contributor
|
its somewhat useless yes, but i would leave the isNvidia() in there anyways incase some oddball nvidia card dont support explicit sync and hits the implicit sync path to not regress that. but the option itself is useless. and could be removed with an wiki PR too. cleaning up is never bad :D |
Contributor
Author
|
done but can't re open the pr I think I broek it edit: it's because i force pushed lol, i just opened another pr |
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
we use explicit sync now so this option is useless afaik. I've been running with the option disabled since the inception of syncobj in Hyprland without issues.
#9361 (comment)
keep the glfinish() there because as stated it may help with sw renderers
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
breaking change that the option is removed i guess
Is it ready for merging, or does it need work?
mhm