Skip to content

feat(flake): substituters#13519

Open
Malix-Labs wants to merge 1 commit intohyprwm:mainfrom
Malix-Labs:patch-1
Open

feat(flake): substituters#13519
Malix-Labs wants to merge 1 commit intohyprwm:mainfrom
Malix-Labs:patch-1

Conversation

@Malix-Labs
Copy link

@Malix-Labs Malix-Labs commented Mar 2, 2026

Describe your PR, what does it fix/add?

feature native substituters suggestion / hint to flake.nix

image

This will also be shown in flake.nix importing this flake

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

No

Is it ready for merging, or does it need work?

Yes

References

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

@fufexan
Copy link
Member

fufexan commented Mar 3, 2026

I'm generally against using nixConfig as upstream Nix does not have a way to ignore it, and forces you to interact. Lix ignores it by default, but not everyone uses it.

The benefits would be minimal, as I don't think anyone runs hyprland with nix run from the flake that often.

@Malix-Labs
Copy link
Author

Malix-Labs commented Mar 3, 2026

As upstream Nix does not have a way to ignore it

Yes this is true,
Is not being able to ignore the sustituters hint an issue?

The benefits would be minimal, as I don't think anyone runs hyprland with nix run from the flake that often.

It would also hint for imperatively adding the keys to nix.conf permanently when you use hyprland as a flake input of a nixos system (and make sure users are aware of the cache)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants