🌟 Day.js 2.0 alpha preview is available

[sxzz]

The v2 branch is here #2066

If you have issues with v2, please comment on this issue. Please do not comment on irrelevant content.

Changelog

• supports ESM

Outdated

The information is outdated, we're planning them released when v3.0.

Changelog

2.0.0-alpha.0

⚠️ At this very early stage, some plugins and locales have not been implemented. (PR welcomed)
⚠️ v2 has been rewritten. The compatibility of any private API is not guaranteed.

Breaking Change

• dayjs.locale(preset, object, isLocal) => dayjs.locale(preset, isLocal, object)
• drop support of node < 14.19.0
• importing plugins or locale (maybe will be changed in the future)
  import 'dayjs/plugin/isToday' > import 'dayjs/dist/plugin/isToday'

Feature

• supports ESM
• rewrite using TypeScript

[benmccann]

Would you be open to a PR to convert the library to ESM for 2.0?

[sxzz]

@benmccann 2.0 supports ESM now, you can try it
https://unpkg.com/browse/@sxzz/dayjs@2.0.0-alpha.2/dist/

[benmccann]

Thanks! Sorry for the noise. I didn't realize that as there wasn't any update on #1765

[vhscom]

I bumped to the v2 alpha (build 2) and it looks like some plugins are missing from the packaged bundles. Things I was looking for are weekOfYear, isBetween and isSameOrAfter though the /dist/plugins directory doesn't seem to include them. Is that a packaging error or are those being rewritten?

[sxzz]

@vhscom

As mentioned in issue content.

At this very early stage, some plugins and locales have not been implemented

[nieaowei]

文档在哪里呢？

[sxzz]

文档在哪里呢？
Where is the documentation?

旧文档也适用
Please refer to 1.x docs

[BePo65]

Perhaps it is a good idea to stay with English in this repository so that everybody can follow the discussions (but perhaps it is a good idea to use it to improve our knowledge of foreign languages - just kidding ;-)

[BePo65]

IMHO it is a good idea to redo the code base for dayjs because this way we have a chance to improve the usability for typescript and add esm support.
I build a minimal angular 13 project to get accustomed to the new version and here are my first findings:

• 'utility-types' is a 'dependencies' (not a 'devDependencies') used in 'units' (resulting in a "cannot find module 'utility-types'" when building my angular app)

• the dist folder does not contain a 'package.json' file after building dayjs.
  It is a good practice - or a requirement? - to include a package.json to a project); even without a dependency, the generated code that will be published to npmjs, should contain a package.json to give information about the project.

• to build version 2, I fetched the next branch, deleted the package-lock.json and the node_modules folder and ran 'npm i'.
  Running 'lint' I got 745 warnings, lots of them stating "Delete ␍eslintprettier/prettier".
  OK, this is an alpha version, so this is not a problem, but the character mentioned in the warning was not an ASCII character (;-), but always at the end of all lines in the referenced files (e.g. in dayjs.ts). Just as I am curious: is this an uncommon line endings character?
  Unluckily I did not find the sources of @sxzz/eslint-config-prettier and @sxzz/eslint-config-ts and their package.json did not contain a 'repository' tag (which is at least a good practice). @sxzz perhaps you could add this tag to your eslint packages?

As a next step, I will add more examples to my test project (e.g. using locales).

If you need a helping hand, I could contribute e.g. one of the plugins. As I am currently working on issue #1596, perhaps I could "migrate" the customParseFormat plugin.

Anyway, thanks for starting this "issue" 👍

[vhscom]

If reworking the code, a rethink on how plugins are included would be nice (especially since only two or three have been implemented). Currently my static analysis tools aren't able to determine when a particular plug-in is no longer used because each is immediately referenced by name within my codebase, e.g.:

import dayjs, { type Dayjs } from 'dayjs';
import weekOfYear from 'dayjs/plugin/weekOfYear.js';
import isBetween from 'dayjs/plugin/isBetween.js';
dayjs.extend(weekOfYear);
dayjs.extend(isBetween);

If I stop using weekOfYear or isBetween my static analysis tools won't tell me.

I realize the way the plug-ins are architected this goal is not easily achievable but perhaps someone knows a technique which might help address this.

[sxzz]

@BePo65

IMHO it is a good idea to redo the code base for dayjs because this way we have a chance to improve the usability for typescript and add esm support. I build a minimal angular 13 project to get accustomed to the new version and here are my first findings:

• 'utility-types' is a 'dependencies' (not a 'devDependencies') used in 'units' (resulting in a "cannot find module 'utility-types'" when building my angular app)

Fixed, f3088ea

• the dist folder does not contain a 'package.json' file after building dayjs.
  It is a good practice - or a requirement? - to include a package.json to a project); even without a dependency, the generated code that will be published to npmjs, should contain a package.json to give information about the project.

It's a good practice, i think. The dist folder only contains bundle code, and other files will located in root folder.

You can see the bundle files here. https://unpkg.com/browse/dayjs@2.0.0-alpha.2/

• to build version 2, I fetched the next branch, deleted the package-lock.json and the node_modules folder and ran 'npm i'.
  Running 'lint' I got 745 warnings, lots of them stating "Delete ␍eslintprettier/prettier".
  OK, this is an alpha version, so this is not a problem, but the character mentioned in the warning was not an ASCII character (;-), but always at the end of all lines in the referenced files (e.g. in dayjs.ts). Just as I am curious: is this an uncommon line endings character?

dayjs 2 uses pnpm now. Please remove node_modules and try pnpm install.

Unluckily I did not find the sources of @sxzz/eslint-config-prettier and @sxzz/eslint-config-ts and their package.json did not contain a 'repository' tag (which is at least a good practice). @sxzz perhaps you could add this tag to your eslint packages?

Source code.

OK, I will add it later.

As a next step, I will add more examples to my test project (e.g. using locales).

If you need a helping hand, I could contribute e.g. one of the plugins. As I am currently working on issue #1596, perhaps I could "migrate" the customParseFormat plugin.

Anyway, thanks for starting this "issue" 👍

That's great. But I don't have a lot of time to focus on open source at the moment, so your PR may not be reviewed in time, but I'll do it as soon as I can. ❤️

[sxzz]

@vhscom
This issue is fixed in v2 branch.

[BePo65]

That's great. But I don't have a lot of time to focus on open source at the moment, so your PR may not be reviewed in time, but I'll do it as soon as I can.

But anyway that is what I call a real fast answer 👍

So I will create a pr for issue #1596 for dayjs v2.0 - will take a few days.