add tensorflow#13
Merged
iancovert merged 2 commits intoiancovert:masterfrom Jul 18, 2022
AndresAlgaba:add_tf
Merged
Conversation
Owner
|
Hi Andres, sorry for the slow response! Thanks for contributing to the package, this is a great idea and a needed addition to the package! And the |
Contributor
Author
|
No problem! My pleasure :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ian, thanks for the wonderful work on the SAGE paper and the accompanying library! I noticed that there was not yet a tensorflow implementation in
model_conversion()and therefore added it in this PR. I modified the airbnb notebook (in airbnb_tf) to show the workflow. I also addedmodel.eval()to the pytorch conversion as I believe it should make it slightly faster. Let me know what you think of these changes, and whether some additional work is required!