Open
Conversation
|
Oh this might be relevant to what I found in #31 |
|
During our tests this fix seems to break things resulting in out of range errors (trying to write negative values). The fix in #31 seems more appropiate. |
Author
|
Unfortunately I am no longer working on the project where the RTF-files caused problem with the then recent implementation so I cannot test the fix #31. But if your tests are successful with the fix and failing without it I assume this PR can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues with characters like \u61607 causing value overflow errors. This led me to the assumption that unicode does indeed use unsigned ints. If you found examples telling the opposite I would like you to show them to me :)