[MERCURE] Add notification handler and update modal title on notifications event#1842
Open
[MERCURE] Add notification handler and update modal title on notifications event#1842
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
admin.notifications.modal.jsto skip the default 30s polling loop if an external notification handler (like Mercure) is detected via a meta tag.setPendingNotificationCountandupdateModalTitleTotalInfo) to ensure the notice dot and notification list refresh automatically when an update is pushed.admin-ui-notification-handlergroup to the main layout, providing a clean entry point for other bundles to inject notification-related logic without hacking existing scripts.This way I could get rid of that ugly hacking with HUGE new interval that was disabling old pooling from outside admin-ui bundle.
For QA:
Just check if notifcations are working as always.
Documentation: