IBX-11401: Fixed embedding default model inheritance and added field name fallback prefixes#719
Open
mikadamczyk wants to merge 1 commit intomainfrom
Open
IBX-11401: Fixed embedding default model inheritance and added field name fallback prefixes#719mikadamczyk wants to merge 1 commit intomainfrom
mikadamczyk wants to merge 1 commit intomainfrom
Conversation
…name fallback prefixes
|
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
reviewed
Feb 27, 2026
Comment on lines
+41
to
+43
| /** | ||
| * @var string[] | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var string[] | |
| */ | |
| /** @var string[] */ |
| * @param array<string, string> $fieldNameMapping | ||
| * @param string[] $fallbackPrefixes | ||
| */ | ||
| public function __construct(array $fieldNameMapping, array $fallbackPrefixes = []) |
Contributor
There was a problem hiding this comment.
Property promotion could be used here.
| public function testGetTypedNameUsesConfiguredMapping(): void | ||
| { | ||
| $generator = new FieldNameGenerator([ | ||
| 'ez_string' => 's', |
Contributor
There was a problem hiding this comment.
😄
Suggested change
| 'ez_string' => 's', | |
| 'ibexa_string' => 's', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains two related core changes needed for Gemini embedding integration and backward-compatible search field naming.
Fixed default_embedding_model inheritance across SiteAccess scopes
Embeddings parser no longer defines a semantic default value for default_embedding_model. A scalar default defined in the semantic config node was being materialized into every SiteAccess/group scope during mapSetting(). This prevented proper inheritance from
system.defaultoverrides (e.g., Gemini config set in project config), because scopes such as site / admin_group ended up with explicit text-embedding-ada-002.ibexa.site_access.config.default.default_embedding_model), so BC is preservedAdded generic field name fallback prefixes in FieldNameGenerator
FieldNameGenerator now supports configurable fallback prefixes used when no explicit field type mapping exists. New embedding models should not require adding a dedicated common.yml mapping entry for every model suffix. We need a generic way to turn
ibexa_dense_vector_<suffix>into backend field suffixsystem.defaultoverride behavior without changing existing explicit SiteAccess/group overridesFor QA:
Documentation: