Bug: path_shorten breaks previewers in `combine()`

[jyn514]

RTFM Checklist

• I have searched exisiting issues / discussions
• I have read the Wiki including the Advanced section
• I have read man fzf / I am well versed in shell fzf

Operating system

macOS Sequoia 15.7.3

Shell

fish

Neovim version (nvim --version)

NVIM v0.11.5

Fzf version (fzf --version)

0.67.0 (Homebrew)

Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))

--cycle --exit-0 --select-1 --preview-window=wrap

Is the problem reproducible with mini.sh?

• My issue is reproducible with mini.sh
• My issue IS NOT reproducible with mini.sh
• I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration

local pickers = require('fzf-lua')
pickers.setup({
	files = {
		path_shorten = true,
        }
})
vim.keymap.set('n', ',f', function()
	pickers.combine({ pickers = "git_files;files" })
end, { desc = "Open file picker" })

Describe the bug / steps to reproduce

1. Press ,f to open the file picker.
2. See entries like the following:

This only happens when the git_files picker comes first; if it comes second everything works fine.

I think the problem here is this bit from the readme:

The first picker options determine the options used by the combined picker, that includes formatters, previewer, path_shorten, etc. To avoid errors combine only pickers of the same entry types (i.e files)

Probably the git picker doesn't support all the same options as the file backend? Maybe it's possible to add them?

[ibhagwan]

Probably the git picker doesn't support all the same options as the file backend? Maybe it's possible to add them?

All options are supported but since you’re combining pickers the previewer expects all entries to be the same, so you can’t have one picker with path_shorten and another without.

This only happens when the git_files picker comes first

If you add path_shorten to git_files or the combine command it will work.

A possible fix is #2516 (comment) from @phanen / @nenahp.

[jyn514]

If you add path_shorten to git_files or the combine command it will work.

oh, this worked like a charm! thank you :)

[ibhagwan]

If you add path_shorten to git_files or the combine command it will work.

oh, this worked like a charm! thank you :)

Great, I’d still like to explore @phanen’s solution using extmarks so we can keep this open.

[ibhagwan]

#2520

[ibhagwan]

cea4145

You can now use winopts.path_shorten instead of path_shorten for an extmarks based approach.