Re-formatting all files using pre-commit hook#1963
Merged
toryhaavik merged 1 commit intoibis-project:masterfrom Sep 13, 2019
Merged
Re-formatting all files using pre-commit hook#1963toryhaavik merged 1 commit intoibis-project:masterfrom
toryhaavik merged 1 commit intoibis-project:masterfrom
Conversation
This was referenced Sep 11, 2019
Merged
Codecov Report
@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 87.67% 86.14% -1.54%
==========================================
Files 93 93
Lines 17088 17088
Branches 2159 2159
==========================================
- Hits 14982 14720 -262
- Misses 1690 1963 +273
+ Partials 416 405 -11
|
xmnlab
force-pushed
the
black-files-formatting
branch
from
f968d8c to
9d1defb
Compare
Contributor
|
You probably want to rebase on top of master, and that will turn off the codecov plugin. |
Contributor
Author
|
@toryhaavik actually I already rebased it. but it seems github didn't understand this change. |
toryhaavik
approved these changes
Sep 13, 2019
Contributor
toryhaavik
left a comment
toryhaavik
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this! Let's keep everything nicely formatted going forward!
costrouc
pushed a commit
to costrouc/ibis
that referenced
this pull request
Oct 10, 2019
waiting for PyCQA/isort#1000 Author: Ivan Ogasawara <ivan.ogasawara@gmail.com> Closes ibis-project#1963 from xmnlab/black-files-formatting and squashes the following commits: 9d1defb [Ivan Ogasawara] Re-formatting all files using pre-commit hook
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waiting for PyCQA/isort#1000