Skip to content

Conversation

@mattparks
Copy link
Contributor

No description provided.

@icculus
Copy link
Owner

icculus commented Jul 12, 2023

Is this because you want to use the CMake project in a subdirectory of a larger project, and having a target named "dist" is causing problems?

Honestly, since releases are just tagged in git and GitHub does the actual tarballs now, we should probably just remove it.

WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
COMMENT "Building source tarball '${PHYSFS_TARBALL}'..."
)
option(PHYSFS_DISABLE_TARBALL "Disable installing PhysFS tar.gz" OFF)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDL conditionally disables installation, and distribution-related options, when it is built as a subdirectory.
The detection happens here.

Also, I would drop the if(UNIX). If it's up to me, Windows users can also create a distribution. But icculus isn't :)

@icculus
Copy link
Owner

icculus commented Dec 17, 2025

@madebr When you have time and are bored, let's make this work like SDL does it. It's not urgent, though.

@madebr
Copy link
Collaborator

madebr commented Dec 17, 2025

@madebr When you have time and are bored, let's make this work like SDL does it. It's not urgent, though.

I disabled source tarball creation from CMake completely in SDL.
Right now, you can create a source tarball through the build-scripts/build-release.py script:

build-scripts/build-release.py --actions source

@icculus
Copy link
Owner

icculus commented Dec 17, 2025

Okay, with the dist target gone, we're good to go here without this PR. Thanks!

@icculus icculus closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants