Allow passing Occurrence to methods that expect a time#570
Open
dawson-conway wants to merge 1 commit intoice-cube-ruby:masterfrom
Open
Allow passing Occurrence to methods that expect a time#570dawson-conway wants to merge 1 commit intoice-cube-ruby:masterfrom
dawson-conway wants to merge 1 commit intoice-cube-ruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make it easier to do something like
Currently this prevents you from serializing the schedule, as the SingleOccurrenceRule has an Occurrence as it's
start_time. When it attempts to serialize the Occurrence as a time, it raises an exception.