iced_glow 0.5.1 crashing with 'location' : not supported for this version or the enabled extensions (GL v3.2)

[greatest-ape]

Is there an existing issue for this?

• I have searched the existing issues.

Is this issue related to iced?

• My hardware is compatible and my graphics drivers are up-to-date.

What happened?

Multiple OctaSine users are seeing crashes since updating to iced_glow 0.5. Detailed issue with error logs. OctaSine currently uses GL v3.2.

I think the crash is due to using location here without enabling ARB_explicit_attrib_location when loading the shader. This seems to be a very similar issue to #1336, which was resolved by these changes to glow_glyph.

What is the expected behavior?

No crash on supported GL versions.

Version

0.6

Operative System

Windows

Do you have any log output?

20:15:01 [ERROR] thread '<unnamed>' panicked at 'ERROR: 0:13: 'location' : not supported for this version or the enabled extensions 
ERROR: 0:13: '' : missing #endif 
ERROR: 0:13: '' : compilation terminated 
ERROR: 3 compilation errors.  No code generated.

[bungoboingo]

Thanks for the report! I also saw this crash recently when testing old GL versions in my most recent PR to add gradients as a background variant. I removed the unsupported explicit layout location declaration in this PR: #1597

Could you try that branch and see if you are still encountering this crash? Thanks!

[greatest-ape]

Nice! I've made a build with your branch active and asked the original issue submitters to try it out.

[greatest-ape]

One of them has answered and says that the crash indeed gets fixed!

Does your PR contain breaking changes? I’m thinking about the chances of getting it released relatively soon :-)

[bungoboingo]

Pretty sure the only breaking changes I made were to the Vertex2D type (removed, replaced with GradientVertex2D, removed the explicit iced_graphics::gradient::Location enum, and slightly changed the constructor for a gradient when using it in a Mesh2D. I think this should be merged pretty soon!

[greatest-ape]

Ok :-)

[greatest-ape]

I've created a smaller PR for fixing this issue: #1703

[greatest-ape]

Fixed through #1703