Merged
Conversation
Mingun
reviewed
Nov 11, 2022
Comment on lines
+353
to
+354
| /// Produces a [`Command`] that moves the cursor of the [`TextInput`] with the given [`Id`] to the | ||
| /// provided position. |
There was a problem hiding this comment.
What's happens if position would be outside range of text? Can be this be prevented by using custom types? That should be documented
Member
Author
There was a problem hiding this comment.
If it's greater than the number of characters in the text input, it just puts the cursor at the end, which is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're missing operations for manipulating the text input cursor / selection of text.
TODOs example is updated to
select_alltext when an entry is edited, which is how the impure example used to work.