Fix Responsive overlay placement bug#1638
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Jan 5, 2023
Merged
Conversation
Layout passed into the overlay was accidentally shadowed by the content's layout. So instead of offsetting by the proper layout, the content layout was used instead.
tarkah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this bug with #1563 🙈 . In trying to please the compiler to satisfy borrow constraints, I accidentally shadowed the
layoutvariable passed into theoverlaymethod with the content's layout. This causes the offset to be incorrect and therefore causes any overlay under aResponsiveto be positioned incorrectly.