Provide &Dependency to Lazy widget view fn#1646
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Jan 12, 2023
Merged
Conversation
&Dependency to Lazy widget View&Dependency to Lazy widget view fn
hecrj
approved these changes
Jan 12, 2023
Member
hecrj
left a comment
There was a problem hiding this comment.
I think it makes sense! Thanks 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small ergonomics improvement that I noticed would be beneficial when working with the
Lazywidget. The change is just to call the provided view function with a reference to the specifiedDependency.This is useful when the data provided for
Dependencyoriginates from the widget tree state, and so we don't have a reference to it which lives for the required'alifetime bound onDependency. In this case we need to take ownership of the data to use it forDependency. Unfortunately, the provided view function must also satisfy the'abound, so the data needs to be cloned again if we want to move it into the view function for use there.By providing view with a reference to the dependency stored in the lazy widget, we can defer this second clone until the cache is actually invalidated rather than doing it on every view. I think it also makes using
Lazya bit more intuitive.I'd be happy to write an RFC if more explanation/examples are required to make this change