Merged
Conversation
Merged
hecrj
force-pushed
the
fix/tooltip-overlay
branch
from
fa1c14d to
65be3f8
Compare
hecrj
approved these changes
Jul 12, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Awesome! Rebased on top of master. Let's merge! 🎉
This was referenced Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the tooltip to an
Overlayinstead of usingrenderer.with_layer.However, I just realized as I'm posting this that it wasn't #1655 that would unblock this, but instead the addition of support for "nested" overlays.
I'll leave this open since the work won't change once unblocked.