Fix panic when using operations with components in certain cases#1701
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Feb 14, 2023
Merged
Fix panic when using operations with components in certain cases#1701hecrj merged 1 commit intoiced-rs:masterfrom
hecrj merged 1 commit intoiced-rs:masterfrom
Conversation
hecrj
approved these changes
Feb 14, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
We are rebuilding the element but not diffing the tree. This breaks contract. It could also make an operation crash.
Fix makes sense. Thanks! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using operations with components nested inside widgets which don't implement operate can cause the application to panic currently. The reason for this is that
Component'soverlayassumes the element will exist, but we do not perform a diff after processing an operation for a component and rebuilding its element. As a result, components lower in the tree contained within widgets which don't forwardoperateto their contents will have their element left asNone, and thus panic when determining their overlay.This PR resolves the issue by diffing a component's widget sub-tree after processing an operation and rebuilding its element.