Sliders no longer bleed over rail#1721
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Feb 20, 2023
Merged
Conversation
hecrj
approved these changes
Feb 20, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Makes sense! Drawing outside of the widget bounds is forbidden as well :)
Thanks!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion for
Sliderto not bleed over the rails.The default behaviour is that
Slidercomes to a stop when the handle ishandle_width / 2over the rail. I would like to propose we only move the handle within the rail. The gif below illustrate the current behaviour as well as my suggestion:I believe this is the most common approach. macOS and Windows references below: