Conversation
hecrj
changed the title
wgpu to 0.15 in iced_wgpu and integration_wgpuwgpu to 0.15
hecrj
approved these changes
Apr 13, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thank you! 🎉
I changed some things here and there, but everything looks good to go!
| capabilities | ||
| .formats | ||
| .iter() | ||
| .filter(|format| format.describe().srgb) |
Member
There was a problem hiding this comment.
This is cool! Hopefully it fixes inaccurate colors for some!
Contributor
Author
There was a problem hiding this comment.
Haha yeah the API is improving a lot, I was surprised too! Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
This is my first time contributing to this amazing project! I was actually trying to add iced as a plugin to my [engine][https://github.com/AryanpurTech/BlueEngine] and I noticed that the wgpu was a version behind, even though it's been a while since it was released, so thought to bump the versions and update the code related to them.
Please review and let me know if it's ok or if I need to update some parts,
thanks,