Do not require Copy for text StyleSheet::Style#1814
Merged
hecrj merged 1 commit intoiced-rs:advanced-textfrom Apr 28, 2023
Merged
Do not require Copy for text StyleSheet::Style#1814hecrj merged 1 commit intoiced-rs:advanced-textfrom
Copy for text StyleSheet::Style#1814hecrj merged 1 commit intoiced-rs:advanced-textfrom
Conversation
hecrj
requested changes
Apr 28, 2023
For most widgets, `Style` only requires `Default`. A few require `Clone`. Only this one requires `Copy`. Some of the types in the default theme has a custom variant requiring `Box<dyn Trait>`, or `Rc<dyn Trait>` to provide `Clone`, but this isn't possible if `Copy` is required. It would be good to also address the inconsistency of requiring `Clone` in some places and not others. This removes `style/src/text.rs` which is unused in this branch and thus confusing. If there's a reason to keep it, that can be removed from the change.
hecrj
approved these changes
Apr 28, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
The current styling system is something I'm still not completely convinced with. That's why some parts may be inconsistent. I'll do a once-over before the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most widgets,
Styleonly requiresDefault. A few requireClone. Only this one requiresCopy.Some of the types in the default theme has a custom variant requiring
Box<dyn Trait>, orRc<dyn Trait>to provideClone, but this isn't possible ifCopyis required.It would be good to also address the inconsistency of requiring
Clonein some places and not others.This removes
style/src/text.rswhich is unused in this branch and thus confusing. If there's a reason to keep it, that can be removed from the change.