fix: tiny-skia svg premultiply final filtered color#1841
Merged
hecrj merged 1 commit intoiced-rs:advanced-textfrom May 9, 2023
Merged
fix: tiny-skia svg premultiply final filtered color#1841hecrj merged 1 commit intoiced-rs:advanced-textfrom
hecrj merged 1 commit intoiced-rs:advanced-textfrom
Conversation
hecrj
approved these changes
May 9, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
I see. Here I was hoping there would be a way to avoid premultiplying every pixel...
Thanks! 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the color is pre-multiplied before grabbing the alpha of the pixel, then the filter color is leaked even what the pixel is completely transparent. This is noticeable if you disable
wgpuand use the dark theme in the svg example.