Remove min width 1 from scrollbar & scroller#1844
Merged
hecrj merged 2 commits intoiced-rs:masterfrom May 23, 2023
Merged
Conversation
hecrj
force-pushed
the
fix/scrollbar-widths
branch
from
4ab2588 to
12a57fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if there's a reason to enforce this, but ideally the user can set it to
0.0to "hide" the scrollbar / scroller.The only way to "hide" the scrollbar / scroller currently is via the stylesheet, which is only aesthetic. This still allows them to be interacted with.
You can test this change by running
scrollableexample. If you set both to 0, the scrollable still works via scrollwheel / trackpad, but the scrollbar / scroller are hidden / don't work. You can even set scrollbar to 0 but keep scroller width to have a floating scroller w/ no scrollbar, which is a feature imo.