Run convert_text on svg trees so text renders correctly#1908
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Nov 11, 2023
Merged
Run convert_text on svg trees so text renders correctly#1908hecrj merged 1 commit intoiced-rs:masterfrom
hecrj merged 1 commit intoiced-rs:masterfrom
Conversation
alec-deason
force-pushed
the
bug/convert_text
branch
from
31167fa to
9081741
Compare
`tiny-skia` does not support text rendering, so we convert the text nodes to path nodes prior to that.
hecrj
force-pushed
the
bug/convert_text
branch
from
9081741 to
2aaaf2c
Compare
hecrj
approved these changes
Nov 11, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Rebased on top of master. Thanks! 🙇
This was referenced Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resvg will not render text unless
.convert_texthas been run on the tree first. This PR does that. This takes one approach to sharing the font database between the text pipeline and the vector pipeline but I'm open to alternatives.Fixes #870.