Fix iced build when using vendored dependencies#1928
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Jun 23, 2023
Merged
Conversation
Contributor
|
Out of curiosity, what's your Flatpak build definition? I haven't had any issues with this in Ludusavi (Flatpak: com.github.mtkennerly.ludusavi.yaml) - granted that I'm not using |
Member
Author
Looks like it's essentially the same. This issue however is from the recent refactor of all the iced crates. So if you're targeting 0.9 or earlier and not master, that's probably why it works for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iced can't be built as a vendored dependency (
cargo vendor) since there is a cross crate include_bytes reference. This fixes that issue by duplicating the font file and making it accessible from each crate needing it.This relates to iced-rs/winit#11 in my efforts to successfully build an iced app w/ Flatpak. Both of these patches unblock and I can get it successfully working. A new PR will be opened to update the winit dep once that is merged.