Add viewport to Widget::on_event#1956
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Jul 15, 2023
Merged
Conversation
hecrj
approved these changes
Jul 15, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Cool! I just needed this!
Thanks 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a widget creator, I want to be able to access viewport in
on_eventto understand if the widget is within view or not. This will allow me to cull expensive event logic for widgets not visible. It will also allow me to create new widgets that can emit messages when they become visible in the viewport (duringRedrawRequested).This specifically allows for creating some nice optimizations and behavior around elements inside a
scrollable.