Added a Frame::scale_nonuniform method #2070
Merged
hecrj merged 3 commits intoiced-rs:masterfrom Sep 7, 2023
ripytide:master
Merged
Added a Frame::scale_nonuniform method #2070hecrj merged 3 commits intoiced-rs:masterfrom ripytide:master
hecrj merged 3 commits intoiced-rs:masterfrom
ripytide:master
Conversation
hecrj
requested changes
Sep 5, 2023
hecrj
reviewed
Sep 5, 2023
ripytide
changed the title
hecrj
approved these changes
Sep 7, 2023
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Made those changes myself! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see no reason why not to make
Frame::scaletake aVectorrather than a singlef32to allow non-same xy scaling.I have tried to update all references I could find in the code-base but may need to rely on the CI to see if I missed any.