use @interpolate(flat) attribute as per the WebGPU spec#2071
Merged
hecrj merged 2 commits intoiced-rs:masterfrom Sep 7, 2023
Merged
use @interpolate(flat) attribute as per the WebGPU spec#2071hecrj merged 2 commits intoiced-rs:masterfrom
hecrj merged 2 commits intoiced-rs:masterfrom
Conversation
User-defined vertex outputs and fragment inputs of scalar or vector integer type must always be specified as @interpolate(flat) https://www.w3.org/TR/WGSL/#interpolation
Davidster
changed the title
hecrj
reviewed
Sep 7, 2023
wgpu/src/shader/quad.wgsl
Outdated
| @location(3) @interpolate(flat) colors_3: vec4<u32>, | ||
| @location(4) @interpolate(flat) colors_4: vec4<u32>, | ||
| @location(5) @interpolate(flat) offsets: vec4<u32>, | ||
| @location(6) @interpolate(flat) direction: vec4<f32>, |
Member
There was a problem hiding this comment.
This one isn't an integer type. I imagine we can revert it.
Contributor
Author
There was a problem hiding this comment.
Oops, yeah that was unintentional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to get iced working with webgpu without this
User-defined vertex outputs and fragment inputs of scalar or vector integer type must always be specified as @interpolate(flat)
https://www.w3.org/TR/WGSL/#interpolation