Workaround issue with winit on windows not resuming the event loop.#2214
Merged
hecrj merged 3 commits intoiced-rs:masterfrom Feb 7, 2024
Merged
Workaround issue with winit on windows not resuming the event loop.#2214hecrj merged 3 commits intoiced-rs:masterfrom
hecrj merged 3 commits intoiced-rs:masterfrom
Conversation
dtzxporter
force-pushed
the
workaround-winit-win32-issues
branch
from
c2a68a9 to
595a5db
Compare
hecrj
force-pushed
the
workaround-winit-win32-issues
branch
from
595a5db to
66823e9
Compare
hecrj
approved these changes
Feb 7, 2024
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I changed the approach to better centralize the workaround. Hopefully that still works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix specific to windows, we can at least process events that are scheduled when the user is resizing the window on win32 platform targets. This workaround can be removed if winit fixes the issue.
Works around: rust-windowing/winit#3272