Add a colored variant for Container style#2261
Merged
hecrj merged 2 commits intoiced-rs:masterfrom Sep 2, 2024
Merged
Conversation
Contributor
|
Instead of adding a new variant, it may make more sense to implement From for the style like some of the other widgets do so you can just have a colored container that way without adding another branch here. |
75aa925 to
969e0d9
Compare
Co-authored-by: wiiznokes <78230769+wiiznokes@users.noreply.github.com>
969e0d9 to
9d7aa11
Compare
hecrj
approved these changes
Sep 2, 2024
Member
hecrj
left a comment
There was a problem hiding this comment.
Made some changes so that the following works:
container.style(container::background(color))Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for debugging