Embedded Scrollbar support for Scrollable#2269
Merged
hecrj merged 2 commits intoiced-rs:masterfrom Jul 11, 2024
Merged
Conversation
hecrj
requested changes
Feb 22, 2024
Contributor
Author
|
CI Issues are unrelated to the PR. |
hecrj
force-pushed
the
scrollbar-disabled
branch
from
a21c219 to
cc804b0
Compare
Co-authored-by: dtzxporter <dtzxporter@users.noreply.github.com>
hecrj
force-pushed
the
scrollbar-disabled
branch
from
cc804b0 to
8ae4e09
Compare
hecrj
approved these changes
Jul 11, 2024
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I ended up reimplementing the feature on top of master and made the scrollbars actually affect content layout when always shown.
hecrj
changed the title
Scrollbar support for Scrollable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled styles are used when a scrollbar is shown, but no content is overflowing.