Support wasm target for download_progress#2419
Merged
hecrj merged 2 commits intoiced-rs:masterfrom Sep 10, 2024
Merged
Conversation
skygrango
force-pushed
the
wasm/support-download_progress
branch
2 times, most recently
from
e4df484 to
5181677
Compare
skygrango
changed the title
download_progress
Co-authored-by: Skygrango <skygrango@gmail.com>
hecrj
force-pushed
the
wasm/support-download_progress
branch
from
9e162a7 to
0053cc0
Compare
hecrj
approved these changes
Sep 10, 2024
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I unified the bytes_stream approach and simplified the example with the new stream::try_channel helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it works, but I did make some tricky modifications because
chunkmethod for wasm, I have to replace chunk by stream