Add background styling to span / rich text#2516
Merged
hecrj merged 7 commits intoiced-rs:masterfrom Jul 28, 2024
Merged
Conversation
tarkah
force-pushed
the
feat/span-background
branch
4 times, most recently
from
1feb29a to
f70edc2
Compare
hecrj
reviewed
Jul 24, 2024
derezzedex
reviewed
Jul 24, 2024
Member
derezzedex
left a comment
derezzedex
left a comment
There was a problem hiding this comment.
I think we could improve the creation of the text::Background with a few helpers, and also possibly changing it to span::Background.
But looks pretty good overall!
hecrj
force-pushed
the
feat/span-background
branch
from
f70edc2 to
4dc7b9b
Compare
hecrj
force-pushed
the
feat/span-background
branch
from
f257b0b to
2796a6b
Compare
hecrj
approved these changes
Jul 28, 2024
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
I simplified some stuff here and there, but looks great! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
text::Backgroundtype which can be optionally specified onSpan.rich_textwill use this to render background quads for spans where this is set.A new
Paragraph::span_boundsmethod is added to get the bounds of each span to enabled this.simplescreenrecorder-2024-07-23_13.37.52.mp4
I'm using this in Halloy: