Open
Conversation
lazytanuki
force-pushed
the
toggle_anim
branch
from
45f1823 to
c8b1037
Compare
lazytanuki
force-pushed
the
toggle_anim
branch
from
c8b1037 to
3e22619
Compare
|
Is there anything new about merging this pr? |
lazytanuki
force-pushed
the
toggle_anim
branch
3 times, most recently
from
bee65bf to
9f68641
Compare
Member
|
This is waiting for me to explore an approach that would introduce an associated type to I'm aware the wait can be a bit frustrating, but hopefully it'll be worth it in the end! I appreciate all the effort here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This is the continuation of #2483 for the 'Toggler' widget animation based on the recently merged #2757.
To respect the
animationsfeature flag, we still use the animation code but the animation is just instantaneous, which IMO reduces the code complexity as opposed to having several features gates.The toggler movement follows an "ease out" animation, and the background color smoothly transitions from one state to the other as well.
I've also included an example crate which is supposed to showcase all animated widgets as they land. ('cargo run -rp animations')
Thanks!
Kooha-2025-02-02-20-08-42.webm