Introduce shader::Pipeline trait for easier wgpu resource management#2876
Closed
AustinEvansWX wants to merge 4 commits intoiced-rs:masterfrom
Closed
Introduce shader::Pipeline trait for easier wgpu resource management#2876AustinEvansWX wants to merge 4 commits intoiced-rs:masterfrom
shader::Pipeline trait for easier wgpu resource management#2876AustinEvansWX wants to merge 4 commits intoiced-rs:masterfrom
Conversation
Member
|
Thanks! Merged manually since I didn't have permissions to push to your branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here on Discord, discarding of cached
wgpuresources can be tricky without knowing when a frame has finished drawing.This PR introduces the
Pipelinetrait which will be required to be implemented for all types put intoStorage. Theend_framemethod on this trait will be triggered following each frame akin to how the internal pipelines havetrim().