Implement FromStr and Display for Color#2937
Merged
hecrj merged 4 commits intoiced-rs:masterfrom Nov 25, 2025
Merged
Conversation
hecrj
added
improvement
hecrj
changed the title
FromStr and Display for ColorFromStr and Display for Color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
Colortype has only a non-standardparsemethod to parse from its string representation, and method to display the color in its string representation is missing.This PR implements
FromStrandDisplaytraits from the standard library using the original implementation of theparsemethod. This allows users to parse and display colors in an easier way, and makes it possible for stuff like#[serde_as(as = "DisplayFromStr")].