Conversation
hugary1995
requested review from
bwspenc,
dschwen,
jiangwen84 and
lindsayad
as code owners
|
Job Precheck, step Clang format on 9dae978 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
| if (this->template getParam<MooseEnum>("dist_norm") != "radius" && | ||
| parameters.isParamSetByUser("axis")) | ||
| this->template paramError("axis", | ||
| this->template paramError<>("axis", |
There was a problem hiding this comment.
@reverendbedford now that I look at this more carefully, I see that all changes are similar to this one. You only made these changes in the solid mechanics module, however. Do you think we need to make similar changes in other modules, too? If so, I wonder if there's another, less intrusive way of fixing this issue...
There was a problem hiding this comment.
Which compiler requires the <>? I've been trying to find this in the standard, but no luck so far.
Most compilers I tried don't seem to require the <>. Or am I missing something peculiar about the paramError template?
There was a problem hiding this comment.
Actually... check this out:
https://godbolt.org/z/8csW6vWe8
Can you try if
| this->template paramError<>("axis", | |
| this->paramError("axis", |
works for you? I believe this is standard compliant and sufficient because the syntax isn't ambiguous! The template keyword is only required to tell the compiler that the < and > aren't comparison operators. But we shouldn't even supply a <> in the first place.
There was a problem hiding this comment.
This will obviously work, as we already have that variant all over our code...
|
@reverendbedford the issue with EigenProblem.C was already fixed in #30469, so I reverted your change. |
|
Job Documentation, step Docs: sync website on 772961b wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 772961b wanted to post the following: Framework coverage
Modules coverageSolid mechanics
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
dschwen
left a comment
dschwen
left a comment
There was a problem hiding this comment.
Let's see if the more compact syntax works for you.
|
I’ll check when I get back but it will be a week.
…On Sat, Jun 14, 2025 at 13:56 Daniel Schwen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In framework/include/userobjects/NearestPointBase.h
<#30761 (comment)>:
> @@ -121,7 +121,7 @@ NearestPointBase<UserObjectType, BaseType>::NearestPointBase(const InputParamete
{
if (this->template getParam<MooseEnum>("dist_norm") != "radius" &&
parameters.isParamSetByUser("axis"))
- this->template paramError("axis",
+ this->template paramError<>("axis",
This will obviously work, as we already have that variant all over our
code...
—
Reply to this email directly, view it on GitHub
<#30761 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZISQ6ZWQXXSPCT7LDEQDT3DRV7DAVCNFSM6AAAAAB7JLVDJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMRYGYZTOMBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This is already in next. Closed by #28114 in a stealth move by @loganharbour |
|
LOL |
|
Pew pew. Found these with clang 19 |
|
Okay, I shouldn't have blindly blamed intel compilers then. I bet it's because the intel compilers on Aurora are wrapping clang 19. Perhaps now is the right time to bring intel compilers back to the moose ecosystem. |
5 participants
Aurora is ANL's new HPC: https://docs.alcf.anl.gov/aurora/
@reverendbedford suffered through the compilation process to get the entire moose stack to work. The minor changes in this PR are required to support MOOSE on Aurora.