Open
Conversation
dschwen
requested review from
GiudGiud,
bwspenc,
grmnptr,
jiangwen84,
lindsayad,
loganharbour,
roystgnr and
zachmprince
as code owners
dschwen
force-pushed
the
std_any_32302
branch
3 times, most recently
from
7f996d2 to
2ee5605
Compare
Contributor
|
Job Test, step Results summary on 2ee5605 wanted to post the following: Framework test summaryCompared against e4407b3 in job civet.inl.gov/job/3542080. No change Modules test summaryCompared against e4407b3 in job civet.inl.gov/job/3542080. No change |
Contributor
|
Job Documentation, step Docs: sync website on 2ee5605 wanted to post the following: View the site here This comment will be updated on new commits. |
Member
|
No concerns here. I've wanted this for a while. Now to fix... |
dschwen
force-pushed
the
std_any_32302
branch
4 times, most recently
from
0a283cc to
218de34
Compare
- Add missing includes (sstream, string, typeindex, libmesh/utility.h) - Fix AnyPtr -> AnyPointer typos in copy/move constructors/operators - Fix member variable references (type -> _type_id, ptr -> _ptr) - Fix initializer list naming (msg_ -> _msg) - Fix typeinfo(void) -> typeid(void) - Add missing semicolon after class definition - Use initializer list in constructor instead of assignment - Add hasValue() method for checking if pointer is set - Handle const pointer conversion properly with const_cast Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- TimeIntegrator now properly passes Communicator reference for _solution_sub and _solution_old_sub serialization (preserves original restartable behavior) - Updated DataIO.C unique_ptr<NumericVector> specializations to accept Communicator& instead of Communicator* - Removed catch-all template for raw pointer serialization from DataIO.h (eliminates ordering fragility where specializations had to come first) - Cleaned up LibtorchArtificialNeuralNet old AnyPointer specializations - Updated test files to use template Context parameter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Converted dataStore/dataLoad specializations in stochastic_tools module from Moose::AnyPointer to templated Context parameter - Updated GaussianProcess, Standardizer, and SnapshotContainerBase - Made Eigen::LLT serialization functions template-based - Removed RestartableModelInterface AnyPointer usage - Updated phase_field FeatureFloodCount serialization - Updated navier_stokes FaceCenteredMapFunctor serialization - Updated xfem GeometricCutUserObject serialization - Added DataIOContext.h with context type traits and compatibility checks This completes the transition from AnyPointer to typed Context templates for all module-level restartable data serialization. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Removes the required_load_context and context_compatible_v trait system from DataIO. The traits were used to provide early compile-time error messages when wrong context types were passed to container dataLoad functions, but added complexity without sufficient benefit. With RestartableData<T, Context> now making context types explicit at compile-time, the natural template instantiation errors are sufficient to catch context mismatches. Changes: - Deleted framework/include/utils/DataIOContext.h - Removed all static_assert calls using context_compatible_v - Removed #include "DataIOContext.h" from DataIO.h - Cleaned up formatting with clang-format The type system itself now enforces context correctness. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dschwen
force-pushed
the
std_any_32302
branch
2 times, most recently
from
a0714bf to
e0b50f7
Compare
Completes the conversion of dataStore/dataLoad functions from using Moose::AnyPointer to templated Context parameters throughout the codebase. This eliminates all type erasure in the serialization system. Framework changes: - MultiApp: Removed AnyPointer handling, kept void* and MultiApp* support - KokkosMaterialPropertyStorage: Converted to template with MooseMesh* instantiation - KokkosArray: Added Context template parameter - LibtorchArtificialNeuralNet: Converted to template - SolutionInvalidity: Converted declarations to templates Module changes: - ray_tracing: Converted Ray dataStore/dataLoad to templates with RayTracingStudy* context - phase_field: Converted GrainTracker and DiscreteNucleationInserterBase - stochastic_tools: Converted PolynomialQuadrature and SnapshotContainerBase Test changes: - Removed Moose::AnyPointer(...) wrappers from all test call sites - Tests now pass raw pointers directly (e.g., `this` instead of `Moose::AnyPointer(this)`) All dataStore/dataLoad functions now use compile-time type-safe Context parameters with no runtime type erasure. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dschwen
force-pushed
the
std_any_32302
branch
from
e0b50f7 to
24924b1
Compare
Contributor
|
Job Precheck, step Clang format on 5e55ad2 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
dschwen
force-pushed
the
std_any_32302
branch
from
5e55ad2 to
f3b193e
Compare
Adds explicit template instantiations to fix linker errors for dataStore/dataLoad functions with various Context types. Instantiations added for: - Basic types (Real, Point, VectorValue, TensorValue, DenseMatrix) with std::nullptr_t and libMesh::MeshBase* contexts - ADReal types with std::nullptr_t context - Elem/Node pointers with libMesh::MeshBase* context - MaterialPropertyStorage and MaterialProperties with appropriate contexts - SolutionInvalidity with std::nullptr_t context - RestartableEquationSystems with MooseMesh* context - PerfGraph with MooseApp* context - NumericVector with const Communicator* context - Test types (RestartableTypesChecker) with appropriate contexts These instantiations are required because the template functions need to be explicitly instantiated for each Context type used in the codebase. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dschwen
force-pushed
the
std_any_32302
branch
from
59a5b8c to
b34aa44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32302