Skip to content

Improve neml2 setup script to look for a pytorch installation#32331

Closed
hugary1995 wants to merge 6 commits intoidaholab:nextfrom
hugary1995:be_nice_neml2
Closed

Improve neml2 setup script to look for a pytorch installation#32331
hugary1995 wants to merge 6 commits intoidaholab:nextfrom
hugary1995:be_nice_neml2

Conversation

@hugary1995
Copy link
Contributor

close #32330

@hugary1995
Copy link
Contributor Author

@loganharbour per our discussion. Do not merge yet. I want to do a neml2 submodule update. You'll notice that I removed dependencies of neml2 on timpi as we removed it.

@hugary1995
Copy link
Contributor Author

Most notably, I changed some logic in neml2.mk (migrating to pkg-config), so let's wait to see if all tests pass. I also tried to make it easy for you to cherry-pick. I dropped dependency on timpi, though I don't expect that to require any change in civet recipes.

@moosebuild
Copy link
Contributor

Job Precheck, step Versioner verify on 4f31254 wanted to post the following:

Versioner templates

Found 14 templates, 0 failed

Versioner influential files

Found 57 influential files, 5 changed, 0 added, 0 removed

package status file
moose-dev CHANGE conda/moose-dev/meta.yaml
moose-dev CHANGE framework/contrib/neml2
moose-dev CHANGE framework/contrib/neml2.mk
moose-dev CHANGE scripts/configure_neml2.sh
moose-dev CHANGE scripts/update_and_rebuild_neml2.sh

Versioner versions

Found 9 packages, 1 changed, 0 failed

package status hash to hash version to version
moose-dev CHANGE 6599578 aa5b44e 2026.02.17 2026.02.19

@moosebuild
Copy link
Contributor

Job Test, step Results summary on 4f31254 wanted to post the following:

Framework test summary

Compared against 5f395a7 in job civet.inl.gov/job/3587370.

No change

Modules test summary

Compared against 5f395a7 in job civet.inl.gov/job/3587370.

No change

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 4f31254 wanted to post the following:

View the site here

This comment will be updated on new commits.

@loganharbour
Copy link
Member

Added to #32379

@hugary1995
Copy link
Contributor Author

This is superseded by #32379

@hugary1995 hugary1995 closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

neml2 setup script could/should check if a python torch exists

3 participants