Skip to content

Ordering of Kokkos-MOOSE and MOOSE UOs#32382

Merged
NamjaeChoi merged 7 commits intoidaholab:nextfrom
NamjaeChoi:kokkos_uo_order
Mar 3, 2026
Merged

Ordering of Kokkos-MOOSE and MOOSE UOs#32382
NamjaeChoi merged 7 commits intoidaholab:nextfrom
NamjaeChoi:kokkos_uo_order

Conversation

@NamjaeChoi
Copy link
Contributor

@NamjaeChoi NamjaeChoi commented Feb 21, 2026

Refs #30655.

I want to handle this better but not sure how... currently this ordering is required by Griffin.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 21, 2026 •
edited
Loading

Job Documentation, step Docs: sync website on 7c4a6fa wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 22, 2026 •
edited
Loading

Job Coverage, step Generate coverage on 7c4a6fa wanted to post the following:

Framework coverage

8c713c #32382 7c4a6f
Total Total +/- New
Rate 85.77% 85.76% -0.01% 100.00%
Hits 128447 128472 +25 228
Misses 21305 21328 +23 0

Diff coverage report

Full coverage report

Modules coverage

Thermal hydraulics

8c713c #32382 7c4a6f
Total Total +/- New
Rate 88.88% 88.88% -0.01% -
Hits 15449 15430 -19 0
Misses 1932 1931 -1 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@NamjaeChoi NamjaeChoi moved this to In progress in NEAMS MP CONNECT/GPU 26 Feb 22, 2026
@NamjaeChoi NamjaeChoi force-pushed the kokkos_uo_order branch 2 times, most recently from f87c75b to 728dcce Compare February 22, 2026 07:14
GiudGiud
GiudGiud requested changes Feb 24, 2026
View reviewed changes
@GiudGiud GiudGiud self-assigned this Feb 24, 2026
@NamjaeChoi NamjaeChoi force-pushed the kokkos_uo_order branch 2 times, most recently from 6992456 to 81404b0 Compare February 24, 2026 23:53
GiudGiud
GiudGiud reviewed Feb 25, 2026
View reviewed changes
@NamjaeChoi
Copy link
Contributor Author

NamjaeChoi commented Feb 25, 2026

This PR is currently based on another one. Will be rebased after that is merged

@NamjaeChoi NamjaeChoi force-pushed the kokkos_uo_order branch 2 times, most recently from b8ea198 to 990e08b Compare February 26, 2026 02:24
@NamjaeChoi
Copy link
Contributor Author

NamjaeChoi commented Feb 26, 2026

@GiudGiud Ready

@NamjaeChoi NamjaeChoi changed the title Execute Kokkos user objects before original user objects Ordering of Kokkos-MOOSE and MOOSE UOs Feb 26, 2026
nmnobre
nmnobre reviewed Feb 26, 2026
View reviewed changes
GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an example of a KokkosGeneralUO in the framework, which will come in handy to have a test as well

GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
@NamjaeChoi NamjaeChoi requested a review from joshuahansel as a code owner March 2, 2026 17:41
@NamjaeChoi
Copy link
Contributor Author

NamjaeChoi commented Mar 2, 2026

I moved SumPostprocessor from T/H module to framework.

GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
GiudGiud
GiudGiud reviewed Mar 2, 2026
View reviewed changes
GiudGiud
GiudGiud requested changes Mar 2, 2026
View reviewed changes
@moosebuild
Copy link
Contributor

moosebuild commented Mar 2, 2026

All jobs on 7c4a6fa : invalidated by @NamjaeChoi

@moosebuild
Copy link
Contributor

moosebuild commented Mar 2, 2026

Job Test, step Results summary on 7c4a6fa wanted to post the following:

Framework test summary

Compared against 8c713c9 in job civet.inl.gov/job/3611922.

Added tests

Test Time (s) Memory (MB)
kokkos/postprocessors/dependency.sum_pp_exec_group 0.83 0.00
kokkos/postprocessors/dependency.sum_pp_wrong_order 0.72 0.00
kokkos/postprocessors/dependency.sum_kokkos_pp 0.71 0.00

Modules test summary

Compared against 8c713c9 in job civet.inl.gov/job/3611922.

No added tests

Run time changes

Test Base (s) Head (s) +/- Base (MB) Head (MB)
solid_mechanics/test:ad_finite_strain_jacobian.3d_bar-jac 5.05 7.68 +52.08% 0.00 0.00

@NamjaeChoi NamjaeChoi merged commit 67abbaf into idaholab:next Mar 3, 2026
70 checks passed
@NamjaeChoi NamjaeChoi deleted the kokkos_uo_order branch March 3, 2026 00:41
@github-project-automation github-project-automation bot moved this from In progress to Done in NEAMS MP CONNECT/GPU 26 Mar 3, 2026
@NamjaeChoi NamjaeChoi mentioned this pull request Mar 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmnobre nmnobre nmnobre left review comments

@GiudGiud GiudGiud GiudGiud approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

@bwspenc bwspenc Awaiting requested review from bwspenc

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84

@dschwen dschwen Awaiting requested review from dschwen

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

@alexanderianblair alexanderianblair Awaiting requested review from alexanderianblair alexanderianblair is a code owner

@loganharbour loganharbour Awaiting requested review from loganharbour

@joshuahansel joshuahansel Awaiting requested review from joshuahansel joshuahansel is a code owner

Assignees

@GiudGiud GiudGiud

Labels

PR: Failed but allowed

Projects

NEAMS MP CONNECT/GPU 26
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NamjaeChoi @moosebuild @GiudGiud @nmnobre