[ ci, test ] Test compiler builded with Racket and some fixes in tests#3688
Open
spcfox wants to merge 11 commits intoidris-lang:mainfrom
Open
[ ci, test ] Test compiler builded with Racket and some fixes in tests#3688spcfox wants to merge 11 commits intoidris-lang:mainfrom
spcfox wants to merge 11 commits intoidris-lang:mainfrom
Conversation
Collaborator
|
I think this re-enabling is reasonable, despite bigger time values, because as far as I remember, we removed those tests prior we had "quick-check" job and prior to decision to stop jobs of the same branch on new commits. None of this arguments are relevant now. Also, putting things in order in backend-related stuff seems to good pretty good. |
Contributor
Author
|
In #3691 I added a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tests
idris/basic/case001andcodegen/enumfail when the compiler is built using Racket. We could have caught this earlier ifubuntu-self-host-racketwere being run in CI. It looks like it was disabled many years ago, and since it is currently running without errors, I propose re-enabling it. I've set the timeout to 60 minutes because Racket runs more slowly than Chez (the other tests use 45 minutes).Some additional fixes to the tests:
runfor tests located in backend directories, as their code generator is specified intests/Main.idr. Specifying the code generator inrunmakes a test less portable, because it causes the test to ignore the code generator set inMain.idr. For example, if such a test is copied from chez to racket, it would still use Chez. Therefore, I suggest avoiding duplication of the code generator specification inrun.codegen/fix3515. Issue Miscompilation ofNatliterals #3515 is not backend-specific, so it’s useful to check thatcompexprhas not changed.findTestsfunction in Golden.Self-check
CONTRIBUTING.mdand I've updated
CONTRIBUTORS.mdwith my name.implementation, I have updated
CHANGELOG_NEXT.md