Silent failure when passing a directory as input#211
Open
LuBashQ wants to merge 2 commits intoifd3f:mainfrom
Open
Silent failure when passing a directory as input#211LuBashQ wants to merge 2 commits intoifd3f:mainfrom
LuBashQ wants to merge 2 commits intoifd3f:mainfrom
Conversation
Image argument must be a file or a symlink to a file. Fixes ifd3f#208 Signed-off-by: LuBashQ <cristian.lupascu.nicolae@gmail.com>
Signed-off-by: LuBashQ <cristian.lupascu.nicolae@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses and closes #208.
imageargument to be a file (or a symbolic link to a file), preventing accidentally passing directoriesType of change
--helpoutputscripts/regenerate_readme.pyfrom the root directory to ensure it has the latest sample outputTest plan
Try to
burna directory, and it should fail with the following errorLog files should contain the file and line number where it was generated