sinttest: Improve extensibility of AbstractMultiUserChatIntegrationTest#689
Open
guusdk wants to merge 1 commit intoigniterealtime:masterfrom
Open
sinttest: Improve extensibility of AbstractMultiUserChatIntegrationTest#689guusdk wants to merge 1 commit intoigniterealtime:masterfrom
guusdk wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
Make fields protected instead of package-private to allow subclasses to reside in other packages, removing the artificial package boundary. Also make static methods public, since protected static has no practical effect and is conceptually inconsistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make fields protected instead of package-private to allow subclasses to reside in other packages, removing the artificial package boundary.
Also make static methods public, since protected static has no practical effect and is conceptually inconsistent.