[core] Presence: add isActive() to check if user is online and can answer#693
Open
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Open
[core] Presence: add isActive() to check if user is online and can answer#693stokito wants to merge 1 commit intoigniterealtime:masterfrom
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
Flowdalic
requested changes
Feb 13, 2026
smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java
Outdated
Show resolved
Hide resolved
smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java
Outdated
Show resolved
Hide resolved
smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java
Outdated
Show resolved
Hide resolved
smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java
Outdated
Show resolved
Hide resolved
…swer Co-authored-by: Florian Schmaus <flo@geekplace.eu>
stokito
force-pushed
the
presence_active
branch
from
67f8ad9 to
b3ca4d8
Compare
Member
Author
|
I applied your suggestions and squashed into a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spark has many places where we need to determine if user is currently online i.e. its status is available or free for chat.
There is even a separate method for this:
https://github.com/igniterealtime/Spark/blob/a64185ad3b4527f764dff680686fc262af48cac1/core/src/main/java/org/jivesoftware/spark/PresenceManager.java#L148
Still there are places in code where to detect it a user is active manually like this:
I would like to propose a separate method
isActiveto simplify usage.